hardcoded language (not translatable)

This is the place to post questions and comments about the FlexBanner component
Post Reply
ruud
Posts: 9
Joined: Mon Nov 17, 2014 8:43 am

hardcoded language (not translatable)

Post by ruud » Tue Nov 18, 2014 8:59 am

Hi,
was wondering if I missed something in the dutch translation but it appears that I didn 't but that a part text is hardcoded in the code lines below:
./components/com_flexbanners/views/client/tmpl/default.php
echo number_format($this->escape($item->impmade),0)." of ".$maximpdisplay;
echo number_format($this->escape($item->clicks,0))." of ".$maxclickdisplay;

the hardcoded text is "of". In dutch this has a different meaning (means: or) and should translate to "van"

I have adjusted the code with the dutch text, but maybe this is a fix for the new version :)
hope this helps!
regards,Ruud.

Andrew998
Posts: 1384
Joined: Wed Jan 07, 2009 10:43 am

Re: hardcoded language (not translatable)

Post by Andrew998 » Wed Nov 19, 2014 11:56 am

Fair point. I'll change it.
Andrew998
Developer

Andrew998
Posts: 1384
Joined: Wed Jan 07, 2009 10:43 am

Re: hardcoded language (not translatable)

Post by Andrew998 » Wed Nov 19, 2014 12:16 pm

Corrected in 4.0.20 and I've added the translation string for the Dutch too.
Andrew998
Developer

ruud
Posts: 9
Joined: Mon Nov 17, 2014 8:43 am

Re: hardcoded language (not translatable)

Post by ruud » Wed Nov 19, 2014 12:38 pm

Hi,

thanks for the new version!
just installed it, got the following warning: JInstaller: :Install: File does not exist /var/www/html/ll_test/tmp/com_flexbanners_update/com_flexbanners/admin/modules/mod_flexbanners/nl-NL.mod_flexbanners.ini

as it turns out the back-end dutch file is not in the package :(

in the front-end language file the following string is missing:
FLEXBANNER_BANNEROF=" van "

hoe this helps!
thanks,
Ruud

Andrew998
Posts: 1384
Joined: Wed Jan 07, 2009 10:43 am

Re: hardcoded language (not translatable)

Post by Andrew998 » Wed Nov 19, 2014 12:42 pm

Whoops, fixed now!
Attachments
com_flexbanners_4.0.20.zip
(284.16 KiB) Downloaded 88 times
Andrew998
Developer

ruud
Posts: 9
Joined: Mon Nov 17, 2014 8:43 am

Re: hardcoded language (not translatable)

Post by ruud » Wed Nov 19, 2014 1:53 pm

Thanks! installed and works :)

Post Reply

Who is online

Users browsing this forum: No registered users and 8 guests