Page 1 of 1

hardcoded language (not translatable)

Posted: Tue Nov 18, 2014 8:59 am
by ruud
Hi,
was wondering if I missed something in the dutch translation but it appears that I didn 't but that a part text is hardcoded in the code lines below:
./components/com_flexbanners/views/client/tmpl/default.php
echo number_format($this->escape($item->impmade),0)." of ".$maximpdisplay;
echo number_format($this->escape($item->clicks,0))." of ".$maxclickdisplay;

the hardcoded text is "of". In dutch this has a different meaning (means: or) and should translate to "van"

I have adjusted the code with the dutch text, but maybe this is a fix for the new version :)
hope this helps!
regards,Ruud.

Re: hardcoded language (not translatable)

Posted: Wed Nov 19, 2014 11:56 am
by Andrew998
Fair point. I'll change it.

Re: hardcoded language (not translatable)

Posted: Wed Nov 19, 2014 12:16 pm
by Andrew998
Corrected in 4.0.20 and I've added the translation string for the Dutch too.

Re: hardcoded language (not translatable)

Posted: Wed Nov 19, 2014 12:38 pm
by ruud
Hi,

thanks for the new version!
just installed it, got the following warning: JInstaller: :Install: File does not exist /var/www/html/ll_test/tmp/com_flexbanners_update/com_flexbanners/admin/modules/mod_flexbanners/nl-NL.mod_flexbanners.ini

as it turns out the back-end dutch file is not in the package :(

in the front-end language file the following string is missing:
FLEXBANNER_BANNEROF=" van "

hoe this helps!
thanks,
Ruud

Re: hardcoded language (not translatable)

Posted: Wed Nov 19, 2014 12:42 pm
by Andrew998
Whoops, fixed now!

Re: hardcoded language (not translatable)

Posted: Wed Nov 19, 2014 1:53 pm
by ruud
Thanks! installed and works :)